test: adjust for boost-histogram 1.3.2's _storage_type deprecation. #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpivarski
requested review from
agoose77 and
henryiii
and removed request for
agoose77
|
Specifically, it's for this: Okay sure, the Python 3.6 case fails because it's getting an older boost-histogram. I'm going to add a fallback to this and #720. |
This was referenced Sep 19, 2022
|
FYI, the reason for the old bh on conda is that 3.6 is dead there, they aren't building new packages for 3.6, and haven't in a while. I would not use conda for 3.6 anymore, it's historical and unsupported at this point. 3.7 might also be following soon(ish). |
jpivarski
deleted the
jpivarski/adjust-for-boost_histogram-1.3.2-storage_type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for all PRs targeting
main.It should be fast-tracked into
mainso that it can be used in all those PRs.