Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracing: Add root level span for periodic tasks #2826

Closed
lukedirtwalker opened this issue Jul 1, 2019 · 1 comment · Fixed by #3709
Closed

tracing: Add root level span for periodic tasks #2826

lukedirtwalker opened this issue Jul 1, 2019 · 1 comment · Fixed by #3709

Comments

@lukedirtwalker
Copy link
Collaborator

We currently have tracing for handlers & messengers but we miss root level spans for periodic tasks.
@lukedirtwalker lukedirtwalker added this to the Q3S1 milestone Jul 1, 2019
@lukedirtwalker lukedirtwalker self-assigned this Jul 1, 2019
@lukedirtwalker lukedirtwalker mentioned this issue Jul 19, 2019
Closed
@scrye scrye modified the milestones: Q3S1, Q3S2 Jul 31, 2019
@scrye scrye removed this from the Q3S2 milestone Oct 28, 2019
@scrye scrye removed the help wanted label Jan 28, 2020
@oncilla
Copy link
Contributor

oncilla commented Apr 14, 2020

addressed by #3709

@oncilla oncilla mentioned this issue Apr 15, 2020
Merged
oncilla added a commit that referenced this issue Apr 15, 2020
@oncilla
tracing: various improvements (#3709)
643d98f 
This PR improves our tracing handling at various places. The error tag
is especially helpful to quickly identify traces that contain errors.

The improvements are:
- Add error tag to spans for beacon, path and trust database operations
- Add result tag to spans for beacon, path and trust database operations
- Add spans to periodic tasks
- Add error tag to svc resolution
- Add error tag to integration tests
- Avoid increasing error counters for failed rollback operations, if the
  the error is `sql.ErrTxDone`.

fixes #2826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tracing: various improvements oncilla/scion
3 participants
@lukedirtwalker @scrye @oncilla