tracing: various improvements #3709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR improves our tracing handling at various places. The error tag is especially helpful to quickly identify traces that contain errors. The improvements are: - Add error tag to spans for beacon, path and trust database operations - Add result tag to spans for beacon, path and trust database operations - Add spans to periodic tasks - Add error tag to svc resolution - Add error tag to integration tests - Avoid increasing error counters for failed rollback operations, if the the error is `sql.ErrTxDone`.
lukedirtwalker
approved these changes
Apr 15, 2020
There was a problem hiding this comment.
Reviewed 17 of 17 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)
a discussion (no related file):
add in the message that it fixes #2826
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves our tracing handling at various places. The error tag
is especially helpful to quickly identify traces that contain errors.
The improvements are:
the error is
sql.ErrTxDone.fixes #2826
This change is