Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Get rid of goconvey #3016

Closed
oncilla opened this issue Aug 20, 2019 · 1 comment · Fixed by #4570
Closed

test: Get rid of goconvey #3016

oncilla opened this issue Aug 20, 2019 · 1 comment · Fixed by #4570
Assignees
@oncilla
Labels
c/testing Everything related to the testing stack refactor Change that focuses around reducing tech debt

Comments

@oncilla
Copy link
Contributor

oncilla commented Aug 20, 2019 •
edited
Loading

Goconvey is slightly painful to work with. Also, upstream seems very inactive.

The vanilla golang sub-tests provide the functionality we need already.
@oncilla oncilla added the Epic label Aug 20, 2019
@lukedirtwalker lukedirtwalker mentioned this issue Sep 17, 2019
Merged
lukedirtwalker added a commit that referenced this issue Sep 19, 2019
@lukedirtwalker
Remove more convey (#3158)
4a2a44d 
Contributes #3016
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Nov 6, 2019
@lukedirtwalker
Convert more goconvey tests to normal go tests
84db0b4 
Contributes scionproto#3016
@lukedirtwalker lukedirtwalker mentioned this issue Nov 6, 2019
Merged
lukedirtwalker added a commit that referenced this issue Nov 7, 2019
@lukedirtwalker
Convert more goconvey tests to normal go tests (#3330)
2ceca10 
Also introduce `xtest.AssertErrorsIs` and use it instead of manual asserts with `xerrors.Is`

Contributes #3016
karampok added a commit to karampok/scion that referenced this issue Nov 8, 2019
@karampok
snet: remove goconvey
7691cc8 
Contributes scionproto#3016
@karampok karampok mentioned this issue Nov 8, 2019
Merged
karampok added a commit to karampok/scion that referenced this issue Nov 11, 2019
@karampok
snet: remove goconvey
bff7c57 
Contributes scionproto#3016
karampok added a commit that referenced this issue Nov 11, 2019
@karampok
snet: remove goconvey (#3350)
cb21f47 
Contributes #3016
karampok added a commit to karampok/scion that referenced this issue Nov 12, 2019
@karampok
godispatcher: remove convey
2f1efd2 
Contributes scionproto#3016
@karampok karampok mentioned this issue Nov 12, 2019
Merged
karampok added a commit to karampok/scion that referenced this issue Nov 14, 2019
@karampok
godispatcher: remove convey
ae38b77 
Contributes scionproto#3016
karampok added a commit to karampok/scion that referenced this issue Nov 14, 2019
@karampok
godispatcher: remove convey
389fb9a 
Contributes scionproto#3016
karampok added a commit that referenced this issue Nov 14, 2019
@karampok
godispatcher: remove convey (#3358)
afda425 
Contributes #3016
@scrye scrye modified the milestone: S01 E01 Jan 7, 2020
karampok added a commit to karampok/scion that referenced this issue Jan 29, 2020
@karampok
Remove convey from tests in lib/addr
4090c9c 
Contributes scionproto#3016
@karampok karampok mentioned this issue Jan 29, 2020
Merged
karampok added a commit that referenced this issue Jan 29, 2020
@karampok
Remove convey from tests in lib/addr (#3643)
a4a0319 
* Remove convey from tests in lib/addr

Contributes #3016
@scrye scrye added the refactor Change that focuses around reducing tech debt label Jan 31, 2020
@matzf matzf mentioned this issue May 27, 2022
Closed
@matzf
Copy link
Contributor

matzf commented May 27, 2022 •
edited
Loading

The following packages still use goconvey:

  • dispatcher/internal/registration (ca 400 LoC) gone
  • pkg/sock/reliable/reconnect (ca 550 LoC) gone
  • private/revcache (~550 LoC)

@matzf matzf added c/testing Everything related to the testing stack and removed Epic labels Jul 11, 2024
@matzf matzf mentioned this issue Jul 11, 2024
Merged
@matzf matzf closed this as completed in 8598eda Jul 15, 2024
lukedirtwalker pushed a commit to lukedirtwalker/scion that referenced this issue Sep 3, 2024
@matzf @lukedirtwalker
CHERRY-PICK: revcache: remove goconvey
60958e5 
Remove use of goconvey from private/revcache, replacing it with the
default go testrunner with subtests and stretchr/testify/assert.

Remove some unused functions instead of updating their tests.

Completely aside: change NewKey to return a Key by value instead of a
reference. It is used as value everywhere and it just hurt my eyes.

Fixes scionproto#3016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oncilla oncilla

Labels
c/testing Everything related to the testing stack refactor Change that focuses around reducing tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

revcache: remove goconvey matzf/scion
3 participants
@scrye @oncilla @matzf