Remove convey from tests in lib/addr #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oncilla
requested changes
Jan 29, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karampok)
go/lib/addr/isdas_test.go, line 2 at r1 (raw file):
// Copyright 2016 ETH Zurich // Copyright 2020 Anapaya Systems
should be // Copyright 2020 ETH Zurich, Anapaya Systems
karampok
commented
Jan 29, 2020
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @oncilla)
go/lib/addr/isdas_test.go, line 2 at r1 (raw file):
Previously, Oncilla wrote…
should be
// Copyright 2020 ETH Zurich, Anapaya Systems
Done.
oncilla
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes #3016
This change is