Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disp: disallow running as root #3067

Closed
kormat opened this issue Aug 30, 2019 · 1 comment · Fixed by #3074
Closed

Disp: disallow running as root #3067

kormat opened this issue Aug 30, 2019 · 1 comment · Fixed by #3074
Assignees
@karampok
Labels
c/dispatcher SCION dispatcher feature New feature or request i/good first issue Good for newcomers

Comments

@kormat
Copy link
Contributor

kormat commented Aug 30, 2019

The BR and SIG both disallow root; the godisp should do the same.
@kormat kormat added the c/dispatcher SCION dispatcher label Aug 30, 2019
@scrye scrye added feature New feature or request i/good first issue Good for newcomers labels Aug 30, 2019
@scrye
Copy link
Contributor

scrye commented Aug 30, 2019 •
edited
Loading

The go/sig and go/border go applications error out if they are executed as root. go/godispatcher should do the same, in a similar way to the others.

@karampok karampok mentioned this issue Sep 2, 2019
Merged
karampok added a commit to karampok/scion that referenced this issue Sep 2, 2019
@karampok
Disp: Do not allow running as root
48f8fa8 
Fixes scionproto#3067
karampok added a commit to karampok/scion that referenced this issue Sep 2, 2019
@karampok
Disp: Do not allow running as root
394f566 
Modify also BR/SIG to avoid package shadowing

Fixes scionproto#3067
karampok added a commit that referenced this issue Sep 2, 2019
@karampok
Disp: Do not allow running as root (#3074)
f5de4c4 
Modify also BR/SIG to avoid package shadowing

Fixes #3067
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karampok karampok

Labels
c/dispatcher SCION dispatcher feature New feature or request i/good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disp: Do not allow running as root karampok/scion
3 participants
@karampok @scrye @kormat