Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disp: Do not allow running as root #3074

Merged
merged 1 commit into from
Sep 2, 2019

Conversation

karampok
Copy link
Contributor

@karampok karampok commented Sep 2, 2019

Fixes #3067


This change is Reviewable

@karampok karampok force-pushed the pub-dispatcher-no-root branch from 3026f84 to 48f8fa8 Compare September 2, 2019 08:02
@karampok karampok requested a review from scrye September 2, 2019 08:04
@scrye scrye added c/dispatcher SCION dispatcher feature New feature or request labels Sep 2, 2019
Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karampok)


go/godispatcher/main.go, line 166 at r1 (raw file):

func checkPerms() error {
	user, err := user.Current()

Varname shadows package name; use a different identifier instead (just u works here, because the function is very small).

@karampok karampok force-pushed the pub-dispatcher-no-root branch from 48f8fa8 to e20c9ff Compare September 2, 2019 14:00
Modify also BR/SIG to avoid package shadowing

Fixes scionproto#3067
@karampok karampok force-pushed the pub-dispatcher-no-root branch from e20c9ff to 394f566 Compare September 2, 2019 14:02
Copy link
Contributor Author

@karampok karampok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @karampok and @scrye)


go/godispatcher/main.go, line 166 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

Varname shadows package name; use a different identifier instead (just u works here, because the function is very small).

Done.

Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@karampok karampok merged commit f5de4c4 into scionproto:master Sep 2, 2019
@karampok karampok deleted the pub-dispatcher-no-root branch September 2, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/dispatcher SCION dispatcher feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disp: disallow running as root
2 participants