Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

segfetcher: Don't fetch core segs, if 0 up/down segments reply is cached. #3094

Closed
lukedirtwalker opened this issue Sep 5, 2019 · 0 comments · Fixed by #3306
Closed

segfetcher: Don't fetch core segs, if 0 up/down segments reply is cached. #3094

lukedirtwalker opened this issue Sep 5, 2019 · 0 comments · Fixed by #3306
Assignees
@lukedirtwalker
Labels
feature New feature or request

Comments

@lukedirtwalker
Copy link
Collaborator

If segfetcher has cached that there are no up/down segments it shouldn't try to fetch connecting core segments to build a path, since the path can't be built anyway.
@lukedirtwalker lukedirtwalker added the feature New feature or request label Sep 5, 2019
@lukedirtwalker lukedirtwalker self-assigned this Sep 5, 2019
This was referenced Oct 31, 2019
Closed
Closed
@lukedirtwalker lukedirtwalker mentioned this issue Nov 4, 2019
Merged
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Nov 4, 2019
@lukedirtwalker
segfetcher: Stop fetch loop on errors
527fcf7 
If we have an error we should not simply ignore it and continue processing.
Instead the fetcher now returns the error immediately.

Also
* do not continue resolving&fetching when 0 up/down segments are cached
* log sciond error code in debug
* remove duplicated log about convergence problem
* improve returned error when a timeout occurs in QUIC

Fixes scionproto#2721
Fixes scionproto#3293
Fixes scionproto#3294
Fixes scionproto#3094
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Nov 4, 2019
@lukedirtwalker
segfetcher: Stop fetch loop on errors
7e83efd 
If we have an error we should not simply ignore it and continue processing.
Instead the fetcher now returns the error immediately.

Also
* do not continue resolving&fetching when 0 up/down segments are cached
* log sciond error code in debug
* remove duplicated log about convergence problem
* improve returned error when a timeout occurs in QUIC

Fixes scionproto#2721
Fixes scionproto#3293
Fixes scionproto#3294
Fixes scionproto#3094
lukedirtwalker added a commit that referenced this issue Nov 4, 2019
@lukedirtwalker
segfetcher: Stop fetch loop on errors (#3306)
dd9be37 
If we have an error we should not simply ignore it and continue processing.
Instead the fetcher now returns the error immediately.

Also
* do not continue resolving&fetching when 0 up/down segments are cached
* log sciond error code in debug
* remove duplicated log about convergence problem
* improve returned error when a timeout occurs in QUIC

Fixes #2721
Fixes #3293
Fixes #3294
Fixes #3094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukedirtwalker lukedirtwalker

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

segfetcher: Stop fetch loop on errors lukedirtwalker/scion
1 participant
@lukedirtwalker