segfetcher: Stop fetch loop on errors #3306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukedirtwalker
force-pushed
the
pubSegFetcherFix
branch
from
475d214 to
527fcf7
Compare
scrye
suggested changes
Nov 4, 2019
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
go/lib/infra/modules/segfetcher/fetcher.go, line 145 at r1 (raw file):
// 2 iteration: up & down resolved, core fetched. // 3 iteration: core resolved -> done. // If we need more than that something breaks assumptions.
I'm struggling with this sentence. What breaks which assumption?
lukedirtwalker
force-pushed
the
pubSegFetcherFix
branch
from
d60eb37 to
5da13fe
Compare
If we have an error we should not simply ignore it and continue processing. Instead the fetcher now returns the error immediately. Also * do not continue resolving&fetching when 0 up/down segments are cached * log sciond error code in debug * remove duplicated log about convergence problem * improve returned error when a timeout occurs in QUIC Fixes scionproto#2721 Fixes scionproto#3293 Fixes scionproto#3294 Fixes scionproto#3094
lukedirtwalker
force-pushed
the
pubSegFetcherFix
branch
from
5da13fe to
268534d
Compare
scrye
approved these changes
Nov 4, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
lukedirtwalker
commented
Nov 4, 2019
There was a problem hiding this comment.
Reviewable status:
go/lib/infra/modules/segfetcher/fetcher.go, line 145 at r1 (raw file):
Previously, scrye (Sergiu Costea) wrote…
I'm struggling with this sentence. What breaks which assumption?
Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have an error we should not simply ignore it and continue processing.
Instead the fetcher now returns the error immediately.
Also
Fixes #2721
Fixes #3293
Fixes #3294
Fixes #3094
This change is