Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monolith PR broke metric naming #3610

Closed
kormat opened this issue Jan 15, 2020 · 0 comments · Fixed by #3611
Closed

Monolith PR broke metric naming #3610

kormat opened this issue Jan 15, 2020 · 0 comments · Fixed by #3611
Assignees
@scrye
Labels
c/observability Metrics, logging, tracing

Comments

@kormat
Copy link
Contributor

kormat commented Jan 15, 2020

#3590 caused metric namespaces to change from service-specific (e.g. bs_ifstate_state) to a misleading one (cs_ifstate_state). This breaks monitoring/alerting.
@kormat kormat added the c/observability Metrics, logging, tracing label Jan 15, 2020
@scrye scrye mentioned this issue Jan 15, 2020
Merged
scrye added a commit that referenced this issue Jan 15, 2020
@scrye
Fix metric names (#3611)
ed5b9a3 
This reverts the metric changes accidentally introduced by
#3590.

Fixes #3610.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scrye scrye

Labels
c/observability Metrics, logging, tracing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix metric names
2 participants
@scrye @kormat