Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metric names #3611

Merged
merged 2 commits into from
Jan 15, 2020
Merged

Fix metric names #3611

merged 2 commits into from
Jan 15, 2020

Conversation

scrye
Copy link
Contributor

@scrye scrye commented Jan 15, 2020

This reverts the metric changes accidentally introduced by
#3590.

Fixes #3610.


This change is Reviewable

This reverts the metric changes accidentally introduced by
#3590.

Fixes #3610.
@scrye scrye requested a review from kormat January 15, 2020 13:27
@scrye scrye self-assigned this Jan 15, 2020
Copy link
Contributor

@kormat kormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 12 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@kormat kormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 15 of 15 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @scrye)

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 12 files at r1, 15 of 15 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @scrye)


go/cs/main.go, line 112 at r2 (raw file):

		return 1
	}
	metrics.InitBSMetrics()

Maybe it would make sense to have a InitMetrics function

@scrye
Copy link
Contributor Author

scrye commented Jan 15, 2020


go/cs/main.go, line 112 at r2 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

Maybe it would make sense to have a InitMetrics function

I think it's a bit more transparent this way; I expect the code around application initialization to get simplified in the near future, so we can revisit this soon.

@scrye scrye merged commit ed5b9a3 into scionproto:master Jan 15, 2020
@scrye scrye deleted the pubpr-fix-metrics branch January 15, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monolith PR broke metric naming
3 participants