You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This test fails for us, as there happens to be a host abc in our network and so this call does not return the expected error.
The cause of this issue is that snet.UDPAddrFromString now uses net.ResolveUDPAddr, which resolves hostnames as documented (emphasis mine):
If the host in the address parameter is not a literal IP address or the port is not a literal port number, ResolveUDPAddr resolves the address to an address of UDP end point. Otherwise, it parses the address as a pair of literal IP address and port number. The address parameter can use a host name, but this is not recommended, because it will return at most one of the host name's IP addresses.
The text was updated successfully, but these errors were encountered:
matzf
added a commit
to matzf/scion
that referenced
this issue
Feb 10, 2020
Parse the host IP, port directly instead of using net.ResolveUDPAddr,
which also resolves hostnames. Hostnames should not be considered inside
SCION addresses.
Fixesscionproto#3654
Parse the host IP, port directly instead of using net.ResolveUDPAddr, which also resolves hostnames. Hostnames should not be considered inside SCION addresses.
Fixes#3654
stygerma
pushed a commit
to stygerma/scion
that referenced
this issue
Mar 26, 2020
Parse the host IP, port directly instead of using net.ResolveUDPAddr, which also resolves hostnames. Hostnames should not be considered inside SCION addresses.
Fixesscionproto#3654
After #3650,
snet.UDPAddrFromString
resolves hostnames in the host part of SCION addresses.This is at least unexpected.
One example can be found in the testcases:
scion/go/lib/snet/udpaddr_test.go
Line 135 in ce1b818
This test fails for us, as there happens to be a host
abc
in our network and so this call does not return the expected error.The cause of this issue is that
snet.UDPAddrFromString
now usesnet.ResolveUDPAddr
, which resolves hostnames as documented (emphasis mine):The text was updated successfully, but these errors were encountered: