Avoid net.ResolveUDPAddr in snet.UDPAddrFromString #3662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse the host IP, port directly instead of using net.ResolveUDPAddr, which also resolves hostnames. Hostnames should not be considered inside SCION addresses. Fixes scionproto#3654
oncilla
requested changes
Feb 11, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matzf)
go/lib/snet/udpaddr.go, line 79 at r1 (raw file):
} port, err := strconv.Atoi(rawPort) if err != nil || 0 > port || port > 65535 {
use strconv.ParseUint(rawPort, 10, 16) instead
Review feedback
matzf
commented
Feb 11, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @oncilla)
go/lib/snet/udpaddr.go, line 79 at r1 (raw file):
Previously, Oncilla wrote…
use
strconv.ParseUint(rawPort, 10, 16)instead
Done.
oncilla
approved these changes
Feb 11, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
stygerma
pushed a commit
to stygerma/scion
that referenced
this pull request
Mar 26, 2020
Parse the host IP, port directly instead of using net.ResolveUDPAddr, which also resolves hostnames. Hostnames should not be considered inside SCION addresses. Fixes scionproto#3654
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse the host IP, port directly instead of using net.ResolveUDPAddr, which also resolves hostnames. Hostnames should not be considered inside SCION addresses.
Fixes #3654
This change is