-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use MinRevTTL instead of constant #3108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @juagargi)
a discussion (no related file):
Please fix the typo in the PR title.
go/beacon_srv/internal/ifstate/revoker_test.go, line 154 at r1 (raw file):
path_mgmt.MinRevTTL / time.Second
I think using path_mgmt.MinRevTTL.Seconds()
would be good, or is there any advantage to use division?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker and @oncilla)
a discussion (no related file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
Please fix the typo in the PR title.
Done.
go/beacon_srv/internal/ifstate/revoker_test.go, line 154 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
path_mgmt.MinRevTTL / time.Second
I think using
path_mgmt.MinRevTTL.Seconds()
would be good, or is there any advantage to use division?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @juagargi and @oncilla)
go/beacon_srv/internal/ifstate/revoker_test.go, line 196 at r2 (raw file):
LinkType: proto.LinkType_peer, RawTimestamp: util.TimeToSecs(time.Now().Add(-6 * time.Second)), RawTTL: 10,
please change here as well.
Closing this in favor of #3111 |
In SCIONLab, if we change the value
path_mgmt.MinRevTTL
from 10 to e.g. 20, some UTs inbeacon_srv
won't pass. Using the constantMinRevTTL
instead of hardcoded10
fixes them.This change is