Configurable RevConfig #3111
Merged
Configurable RevConfig #3111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oncilla
requested changes
Sep 6, 2019
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @juagargi)
go/beacon_srv/internal/config/config.go, line 50 at r1 (raw file):
DefaultExpiredCheckInterval = 200 * time.Millisecond // DefaultRevTTL is the default revocation TTL. DefaultRevTTL = 10 * time.Second
use path_mgmt.MinRevTTL
juagargi
commented
Sep 6, 2019
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)
go/beacon_srv/internal/config/config.go, line 50 at r1 (raw file):
Previously, Oncilla wrote…
use
path_mgmt.MinRevTTL
Done.
oncilla
approved these changes
Sep 6, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
juagargi
added a commit
to netsec-ethz/scion
that referenced
this pull request
Sep 9, 2019
The values in ifstate.RevConfig are now configurable via beacon server config file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The values in
ifstate.RevConfigare now configurable viaBSConfig.Also adapt/add UTs.
This change is