Delete py_ext_integration test #3424
Conversation
It tested a path extension which we do not have in Go code, and might possibly be redesigned. Testing extensions in general is done by our end2end test since the beacon server uses one hop extension. Therefore this can be deleted without replacement for now.
There was a problem hiding this comment.
Reviewed 5 of 7 files at r1.
Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
python/integration/set_ipv6_addr.py, line 1 at r1 (raw file):
#!/usr/bin/python3
I was told we cannot remove that.
There was a problem hiding this comment.
Reviewable status: 5 of 7 files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker)
a discussion (no related file):
go/integration/scmp_error_pyintegration can also be removed?
There was a problem hiding this comment.
Reviewable status: 5 of 7 files reviewed, 2 unresolved discussions (waiting on @worxli)
a discussion (no related file):
Previously, worxli (Lukas Bischofberger) wrote…
go/integration/scmp_error_pyintegrationcan also be removed?
No not yet, there is an issue: #3422 for it.
python/integration/set_ipv6_addr.py, line 1 at r1 (raw file):
Previously, worxli (Lukas Bischofberger) wrote…
I was told we cannot remove that.
Done.
lukedirtwalker
force-pushed
the
pubKillPyExtTest
branch
from
bd8bd49 to
7846b3b
Compare
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
a discussion (no related file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
No not yet, there is an issue: #3422 for it.
Sorry I meant: go/integration/cli_srv_ext_pyintegration
There was a problem hiding this comment.
Reviewed 1 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @worxli)
a discussion (no related file):
Previously, worxli (Lukas Bischofberger) wrote…
Sorry I meant:
go/integration/cli_srv_ext_pyintegration
Done.
There was a problem hiding this comment.
Reviewed 3 of 3 files at r3.
Reviewable status:
It tested a path extension which we do not have in Go code, and might possibly be redesigned.
Testing extensions in general is done by our end2end test since the beacon server uses one hop extension.
Therefore this can be deleted without replacement for now.
This change is