-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/private: cleanup common, util, xtest packages #4311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 59 of 59 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @oncilla)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 59 of 59 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matzf and @oncilla)
tools/integration/integration.go
line 1 at r1 (raw file):
// Copyright 2018 Anapaya Systemduring
revert that
Suggestion:
Systems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 58 of 59 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker, @marcfrei, and @oncilla)
tools/integration/integration.go
line 1 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
revert that
Yes, oops! Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @oncilla)
Only used to compute reference value in slayers test cases. Use a simpler, non-optimized implementation for this.
No longer needed. Native byte order is not often needed, but will eventually show up in standard library anyway (golang/go#57237).
5abc504
to
c6fe8ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 58 of 59 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matzf)
pkg/private/util/checksum.go
line 25 at r3 (raw file):
// Calculate RFC1071 checksum of supplied data chunks. If a chunk has // an odd length, it is padded with a 0 during checksum computation. func Checksum(srcs ...[]byte) uint16 {
Just as an FYI, this implementation was ~2 times as fast as the slayers implementation the last time I benchmarked.
But given it is not used, we don't need to keep it around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matzf)
The pkg/private/common, util and xtest packages have rather fuzzy scope, and have accumulated a bit of cruft and unused or outdated functionality. Clean this up a bit:
Native byte order is not often needed, but will eventually show up in standard library anyway (encoding/binary: add var NativeEndian; also x/sys/cpu.IsBigEndian golang/go#57237).
There are still more things to clean up in
pkg/private
, in future PRs, in particular:common.ErrMsg
should be integrated inserrors
common.IFIDType
should be removed or renamed and moved somewhere more appropriateutil
andcommon
LinkType
andRevInfo
frompkg/private/ctrl
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)