Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/private: cleanup common, util, xtest packages #4311

Merged
merged 12 commits into from
Feb 9, 2023
Merged

pkg/private: cleanup common, util, xtest packages #4311

merged 12 commits into from
Feb 9, 2023

Commits on Feb 3, 2023

  1. pkg/private/util: remove unused helper functionality

    @matzf
    matzf committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    db0b86c View commit details
    Browse the repository at this point in the history

  2. pkg/private/common: remove unused constants

    @matzf
    matzf committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    cf5b152 View commit details
    Browse the repository at this point in the history

  3. pkg/private/common: remove outdated error handling helpers and replac… 

    …e remaining use
    @matzf
    matzf committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    02ef3f4 View commit details
    Browse the repository at this point in the history

  4. xtest: replace AssertErrorsIs with assert.ErrorIs

    @matzf
    matzf committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    f91a61e View commit details
    Browse the repository at this point in the history

  5. xtest: replace FailOnErr with require.NoError

    @matzf
    matzf committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    d5af2fd View commit details
    Browse the repository at this point in the history

  6. xtest: remove unused Callback and MockCallback

    @matzf
    matzf committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    d170907 View commit details
    Browse the repository at this point in the history

  7. xtest: remove unused helpers

    @matzf
    matzf committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    6f9450f View commit details
    Browse the repository at this point in the history

  8. pkg/private/util: move ASList to tools/integration

    @matzf
    matzf committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    d2b99fe View commit details
    Browse the repository at this point in the history

  9. pkg/private/util: move RunsInDocker to private/env

    @matzf
    matzf committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    a6dbc9d View commit details
    Browse the repository at this point in the history

  10. pkg/private/util: remove Checksum 

    Only used to compute reference value in slayers test cases. Use a
simpler, non-optimized implementation for this.
    @matzf
    matzf committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    c9609c3 View commit details
    Browse the repository at this point in the history

  11. pkg/private/common: remove NativeOrder and IsBigEndian 

    No longer needed.
Native byte order is not often needed, but will eventually show up in
standard library anyway (golang/go#57237).
    @matzf
    matzf committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    346e06d View commit details
    Browse the repository at this point in the history

  12. fixup

    @matzf
    matzf committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    c6fe8ef View commit details
    Browse the repository at this point in the history