deps: use v2 of go-toml #4342
deps: use v2 of go-toml #4342
Conversation
There was a problem hiding this comment.
Reviewed 26 of 26 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker and @oncilla)
a discussion (no related file):
In control/config/config.go:161, in struct BSConfig, we have EPIC bool with the tag toml:"epic,omitempty" default:"false".
According to the migration guide, the default tag is no longer supported. I think we can just remove it.
private/trust/config/config.go line 52 at r1 (raw file):
type Cache struct { Disable bool `toml:"disable,omitempty"` Expiration util.DurWrap `toml:"expiration,omitempty"`
Good fix. Just for completeness, please note in the PR/commit description that this is a breaking change of the configuration format in this particular field.
There was a problem hiding this comment.
Reviewed 26 of 26 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
private/trust/config/config.go line 52 at r1 (raw file):
Previously, matzf (Matthias Frei) wrote…
Good fix. Just for completeness, please note in the PR/commit description that this is a breaking change of the configuration format in this particular field.
This has been changed in #4417, so nevermind.
v1 is no longer maintained.
There was a problem hiding this comment.
Reviewed 4 of 7 files at r2, 3 of 3 files at r3, 2 of 2 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @lukedirtwalker)
v1 is no longer maintained.
This change is