control: formatted duration for config trustengine.cache.expiration #4417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oncilla
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matzf)
matzf
force-pushed
the
control-trust-cfg-durwrap
branch
2 times, most recently
from
27b77e2 to
83ada65
Compare
matzf
force-pushed
the
control-trust-cfg-durwrap
branch
from
77fdef1 to
fbeed3d
Compare
oncilla
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Reviewed 2 of 3 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status:
The `trustengine.cache.expiration` configuration option would accept durations as number of nanoseconds. Most likely, this was accidental, all other configuration options for durations accept formatted duration strings, with unit suffix. Change `trustengine.cache.expiration` to accept (only) formatted duration strings. This is a potentially compatibility breaking change for existing control service configuration files. The `trustengine.cache` configuration block is marked as experimental and is likely not widely used, so no transition mechanism is added.
matzf
force-pushed
the
control-trust-cfg-durwrap
branch
from
fbeed3d to
3d1cc70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
trustengine.cache.expirationconfiguration option would accept durations as number of nanoseconds. Most likely, this was accidental, all other configuration options for durations accept formatted duration strings, with unit suffix.Change
trustengine.cache.expirationto accept (only) formatted duration strings.This is a potentially compatibility breaking change for existing control service configuration files.
The
trustengine.cacheconfiguration block is marked as experimental and is likely not widely used, so no transition mechanism is added.This change is