Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed properties from score spec #45

Merged
merged 5 commits into from
Jul 24, 2023
Merged

removed properties from score spec #45

merged 5 commits into from
Jul 24, 2023

Conversation

rachfop
Copy link
Contributor

@rachfop rachfop commented Jun 6, 2023

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What is the motivation?

What does this change do?

Provide a description of what this pull request does.

What is your testing strategy?

Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.

Is this related to any issues?

If this pull request is related to any other pull request or issue, or resolves any issues - then link all related pull requests and issues here.

Have you read the Contributing Guidelines?

@rachfop rachfop requested a review from sujaya-sys June 7, 2023 16:16
Copy link

@ghen ghen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several fixes are needed.

content/en/docs/reference/score-spec-reference.md Outdated Show resolved Hide resolved
content/en/docs/dependencies/_index.md Outdated Show resolved Hide resolved
content/en/docs/dependencies/dependencies-humanitec.md Outdated Show resolved Hide resolved
content/en/docs/extensions/_index.md Outdated Show resolved Hide resolved
content/en/docs/extensions/_index.md Outdated Show resolved Hide resolved
content/en/docs/get started/Transform/_index.md Outdated Show resolved Hide resolved
content/en/docs/get started/Transform/docker.md Outdated Show resolved Hide resolved
content/en/docs/reference/score-spec-reference.md Outdated Show resolved Hide resolved
content/en/docs/reference/score-spec-reference.md Outdated Show resolved Hide resolved
Copy link

@ghen ghen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some leftovers in YAML that should be removed.

content/en/docs/dependencies/_index.md Outdated Show resolved Hide resolved
content/en/docs/dependencies/dependencies-humanitec.md Outdated Show resolved Hide resolved
rachfop and others added 2 commits July 18, 2023 07:48
Signed-off-by: Patrick Rachford <64233065+rachfop@users.noreply.github.com>
@rachfop rachfop merged commit 73a44a9 into main Jul 24, 2023
1 check failed
@rachfop rachfop deleted the remove-properties branch July 24, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants