Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed properties from score spec #34

Merged
merged 5 commits into from
Jul 4, 2023
Merged

removed properties from score spec #34

merged 5 commits into from
Jul 4, 2023

Conversation

sujaya-sys
Copy link
Contributor

Description

We are planning to deprecate resource properties in the Score spec: score-spec/spec#61

What does this PR do?

It removes resource properties from the example score.yaml files we store in this repo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

Copy link
Contributor

@ghen ghen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI code needs to be updated. Otherwise these examples won't work and that would confuse the users.

Please wait for code changes before approving/merging these changes.

ghen and others added 4 commits June 15, 2023 16:34
Signed-off-by: Eugene Yarshevich <yarshevich@gmail.com>
Signed-off-by: Eugene Yarshevich <yarshevich@gmail.com>
Signed-off-by: Eugene Yarshevich <yarshevich@gmail.com>
@ghen ghen self-requested a review June 15, 2023 14:58
Copy link
Contributor

@ghen ghen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Would appreciate someone else to take a look too

Copy link

@chrishumanitec chrishumanitec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghen ghen merged commit c1ef740 into main Jul 4, 2023
@ghen ghen deleted the update-examples-compose branch July 4, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants