Sanitize version names when creating egg paths. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branches that contain invalid filesystem characters (or special filesystem characters) would have them passed as such. This patch replaces non alphanumeric + [-_] characters with underscores. As an example, a spider deployed from git branch "feature/x_y" would attempt to store the egg in a nonexistent directory called "feature" and fail.
pablohoffman
added a commit
that referenced
this pull request
Dec 24, 2014
Sanitize version names when creating egg paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branches that contain invalid filesystem characters (or special
filesystem characters) would have them passed as such. This patch
replaces non alphanumeric + [-_] characters with underscores.
As an example, a spider deployed from git branch "feature/x_y" would
attempt to store the egg in a nonexistent directory called "feature"
and fail.