New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize version names when creating egg paths. #72

Merged

pablohoffman merged 1 commit into scrapy:master from andrewbaxter:sanitize_eggpaths

Dec 24, 2014

Commits on Dec 20, 2014

Sanitize version names when creating egg paths.

Branches that contain invalid filesystem characters (or special
filesystem characters) would have them passed as such.  This patch
replaces non alphanumeric + [-_] characters with underscores.

As an example, a spider deployed from git branch "feature/x_y" would
attempt to store the egg in a nonexistent directory called "feature"
and fail.

Andrew Baxter committed Dec 20, 2014