Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(1769): [2] Change data structure for queue-service cooperation. #90

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -168,12 +168,12 @@ class ScmBase {
/**
* Parse the webhook to get the changed files
* @method getChangedFiles
* @param {Object} config Configuration
* @param {String} config.type The type of action from Git (can be 'pr' or 'repo')
* @param {Object} config.payload The webhook payload received from the SCM service
* @param {String} config.token The token used to authenticate to the SCM
* @param {String} [config.scmContext] The scm context name
* @return {Promise} Returns an array of changed files
* @param {Object} config Configuration
* @param {String} config.type The type of action from Git (can be 'pr' or 'repo')
* @param {Object} config.webhookConfig The webhook payload received from the SCM service
* @param {String} config.token The token used to authenticate to the SCM
* @param {String} [config.scmContext] The scm context name
* @return {Promise} Returns an array of changed files
*/
getChangedFiles(config) {
return validate(config, dataSchema.plugins.scm.getChangedFilesInput)
Expand Down
8 changes: 5 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,11 @@
"main": "index.js",
"scripts": {
"pretest": "eslint .",
"test": "nyc --report-dir ./artifacts/coverage --reporter=lcov mocha --reporter mocha-multi-reporters --reporter-options configFile=./mocha.config.json --recursive --timeout 4000 --retries 1 --exit --allow-uncaught true --color true",
"semantic-release": "semantic-release pre && npm publish && semantic-release post"
"test": "nyc --report-dir ./artifacts/coverage --reporter=lcov mocha --reporter mocha-multi-reporters --reporter-options configFile=./mocha.config.json --recursive --timeout 4000 --retries 1 --exit --allow-uncaught true --color true"
},
"repository": {
"type": "git",
"url": "git@github.com:screwdriver-cd/scm-base.git"
"url": "git+https://github.com/screwdriver-cd/scm-base.git"
},
"homepage": "https://github.com/screwdriver-cd/scm-base",
"bugs": "https://github.com/screwdriver-cd/scm-base/issues",
Expand All @@ -31,6 +30,9 @@
"Tiffany Kyi <tiffanykyi@gmail.com>"
],
"release": {
"branches": [
"master"
],
"debug": false,
"verifyConditions": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove verifyConditions

"path": "./node_modules/semantic-release/src/lib/plugin-noop.js"
Expand Down