feat(1769): [3] Change data structure for queue-service cooperation. BREAKING CHANGE: screwdriver-api no longer works. #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yk634
changed the title
This was referenced Dec 20, 2021
Merged
yk634
changed the title
tk3fftk
reviewed
Dec 21, 2021
| @@ -13,11 +13,13 @@ const testPayloadPushTag = require('./data/github.push.tag.json'); | |||
| const testPayloadRelease = require('./data/github.release.json'); | |||
| const testPayloadReleaseBadAction = require('./data/github.release.badAction.json'); | |||
| const testPayloadTag = require('./data/github.tag.json'); | |||
| const testPayloadPushBadHead = require('./data/github.push.badHead.json'); | |||
There was a problem hiding this comment.
Can we also remove ./data/github.push.badHead.json file?
| "hookId": "3c77bf80-9a2f-11e6-80d6-72f7fe03ea29", | ||
| "scmContext": "github:github.com", | ||
| "action": "opened" | ||
| } |
There was a problem hiding this comment.
no new line at the end of file👀
There was a problem hiding this comment.
I added new line to the files.
wahapo
reviewed
Dec 21, 2021
There was a problem hiding this comment.
Does this need BREAKING CHANGE: MESSAGE?
https://docs.screwdriver.cd/about/contributing/
yk634
changed the title
yk634
changed the title
wahapo
approved these changes
Dec 21, 2021
y-oksaku
approved these changes
Dec 21, 2021
itleigns
approved these changes
Dec 21, 2021
tkyi
approved these changes
Dec 22, 2021
kumada626
approved these changes
Dec 24, 2021
ibu1224
approved these changes
Dec 24, 2021
|
🎉 This PR is included in version 11.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Change the data structure so that getChangedFiles can be executed from the endpoint
/processHooksadded in screwdriver-cd/screwdriver#2622.Objective
This is a breaking change, because the arguments to getChangedFiles will be renamed, and the caller of that function will need to be modified as well.
That modification is done at screwdriver-cd/screwdriver#2622.
References
Because of the changes in the data structure, the unit test may fail until the changes in data-schema are published.
data-schema PR
scm-base PR
scm-gitlab PR
screwdriver PR
screwdriver-cd/screwdriver#1769 (comment)
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.