feat(1769): [1] Add property to SCHEMA_HOOK #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yk634
changed the title
This was referenced Dec 20, 2021
Merged
yk634
changed the title
y-oksaku
reviewed
Dec 20, 2021
| .optional() | ||
| .label('Modified files of head commit'), | ||
|
|
||
| removedFiles: Joi.array() |
There was a problem hiding this comment.
deleted is used in git command, so I think that it is better to use deleted instead of removed.
There was a problem hiding this comment.
The GitHub and GitLab webhook specification treats deleted files as removed, so I think it's better to leave them as removed.
wahapo
approved these changes
Dec 21, 2021
y-oksaku
approved these changes
Dec 21, 2021
itleigns
approved these changes
Dec 21, 2021
tkyi
approved these changes
Dec 22, 2021
kumada626
approved these changes
Dec 24, 2021
ibu1224
approved these changes
Dec 24, 2021
|
🎉 This PR is included in version 21.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
To support the changes in screwdriver-cd/scm-github#200, I change the data structure associated with SCM.
Objective
References
scm-base PR
scm-github PR
scm-gitlab PR
screwdriver PR
screwdriver-cd/screwdriver#1769 (comment)
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.