-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SERF-498] Upgrade gorm to v2 #58
Conversation
4f40d42
to
afb4ef2
Compare
1c933b4
to
e0ab410
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👍 gorm
introduced lots of changes and improvements
I did a first quick pass and placed some comments 💬
e0ab410
to
7f1ce3f
Compare
7f1ce3f
to
cfa3d41
Compare
cfa3d41
to
76160a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Great work 👍
I would wait for another reviewer to approve, maybe they could spot something else 👀
Also, very good idea to test this PR in real life application (document-search
) in a development environment before merging. Check logs, traces and overall update ✅
76160a6
to
bfca459
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
bfca459
to
56a8297
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
56a8297
to
ff0da41
Compare
Thanks for the review 🙏 (with a bit of a delay :) ) Also you mind sharing a DataDog link about SQL logging field, please? |
To give an update on my comment regarding gorm's behavior on logging PII:
|
30bff4a
to
738ddfd
Compare
Along with "go mod tidy"
cf33e2a
to
a9c3877
Compare
a9c3877
to
19d6969
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
For posterity, here's a log example in |
Description
Works done:
github.com/jinzhu/gorm
withgorm.io/gorm
(nogo mod tidy
yet)gorm.io/driver/*
gorm.io/gorm/logger
along with tests.Testing considerations
Running
docker-compose run --rm sdk mage test:run
must be smooth.Running new sdk update on chassis must go OK too:
Checklist
development
and/orstaging
README.md
as necessaryRelated links