[SERF-498] Fix passing data using context in Gorm #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an issue in
instrumentation
package when passing the data within context and the result was that there were no metrics (or basically no metrics in database context) as is seen here for example.The fix was to use
db.Statement.Context
instead ofdb.Set()
as it's suggestion in the new version of gorm documentation.There is also new unit test to cover the issue for future references.
Testing considerations
The work was tested in
document-search
development and the result trace can be seen here.Checklist
development
and/orstaging
README.md
as necessaryRelated links