Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scroll-worker): add nil consumption block metrics #1033

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Sep 10, 2024

1. Purpose or design rationale of this PR

  • record missing row consumption during restart.
  • record missing ancestor's row consumption during runtime.

for scroll-worker panic, should be caught by "panic" in the logs of the below training wheel, thus this PR does not add this metric:

defer func() {
	// training wheels on
	// lets not crash the node and allow us some time to inspect
	p := recover()
	if p != nil {
		log.Error("worker mainLoop panic", "panic", p)
	}
}()

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change

0xmountaintop
0xmountaintop previously approved these changes Sep 11, 2024
omerfirmak
omerfirmak previously approved these changes Sep 11, 2024
@colinlyguo colinlyguo dismissed stale reviews from omerfirmak and 0xmountaintop via be56771 September 16, 2024 14:02
@colinlyguo colinlyguo merged commit 1d02d04 into develop Sep 17, 2024
8 checks passed
@colinlyguo colinlyguo deleted the add-immediate-metrics-when-nil-row-consumption branch September 17, 2024 14:03
@0xmountaintop 0xmountaintop mentioned this pull request Oct 10, 2024
5 tasks
0xmountaintop pushed a commit that referenced this pull request Oct 10, 2024
* feat(scroll-worker): add nil consumption block metrics

* increase the version
0xmountaintop added a commit that referenced this pull request Oct 10, 2024
feat(scroll-worker): add nil consumption block metrics (#1033)

* feat(scroll-worker): add nil consumption block metrics

* increase the version

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants