Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: darwinv2 #1484

Merged
merged 22 commits into from
Aug 23, 2024
Merged

feat: darwinv2 #1484

merged 22 commits into from
Aug 23, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Aug 18, 2024

Purpose or design rationale of this PR

IsDarwinV2 controls whether or not to use codecv4.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 19.36759% with 204 lines in your changes missing coverage. Please review.

Project coverage is 51.71%. Comparing base (e09b98f) to head (d3e5408).
Report is 1 commits behind head on develop.

Files Patch % Lines
rollup/internal/utils/utils.go 0.00% 90 Missing ⚠️
rollup/internal/controller/relayer/l2_relayer.go 17.02% 39 Missing ⚠️
coordinator/internal/orm/l2_block.go 0.00% 35 Missing ⚠️
coordinator/cmd/api/app/mock_app.go 0.00% 16 Missing ⚠️
coordinator/internal/orm/batch.go 0.00% 10 Missing ⚠️
...llup/internal/controller/watcher/batch_proposer.go 66.66% 7 Missing ⚠️
...llup/internal/controller/watcher/chunk_proposer.go 69.56% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1484      +/-   ##
===========================================
- Coverage    52.21%   51.71%   -0.51%     
===========================================
  Files          156      156              
  Lines        12603    12763     +160     
===========================================
+ Hits          6581     6600      +19     
- Misses        5455     5595     +140     
- Partials       567      568       +1     
Flag Coverage Δ
common 42.98% <ø> (ø)
coordinator 17.22% <1.61%> (-0.20%) ⬇️
database 42.85% <ø> (ø)
rollup 55.65% <25.13%> (-1.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rollup/conf/config.json Outdated Show resolved Hide resolved
@colinlyguo colinlyguo added the bump-version Bump the version tag for deployment label Aug 22, 2024
@colinlyguo colinlyguo changed the title feat(rollup-relayer): codecv4 feat: darwin v2 Aug 23, 2024
@colinlyguo colinlyguo changed the title feat: darwin v2 feat: darwinv2 Aug 23, 2024
colinlyguo and others added 2 commits August 23, 2024 17:45
Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
Co-authored-by: Mengran Lan <mengran@scroll.io>
Co-authored-by: georgehao <haohongfan@gmail.com>
georgehao
georgehao previously approved these changes Aug 23, 2024
@georgehao georgehao merged commit fa80b3e into develop Aug 23, 2024
18 checks passed
@georgehao georgehao deleted the feat-rollup-relayer-codecv4 branch August 23, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants