Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce UncheckedExtrinsicV4 for submit_extrinsic and add _opaque_extrinsic #421

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Enforce UncheckedExtrinsicV4 for submit_extrinsic and add _opaque_extrinsic #421

merged 2 commits into from
Jan 9, 2023

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Jan 5, 2023 •
edited
Loading

Renames current extrinsic submission to opaque and add new, more restrictive submit_extrinisc and similiar functions instead. This way, the encoding does not have to be implemented on client side and is less error prone as UncheckedExtrinsicV4 type is enforced.

closes #90

@haerdib haerdib self-assigned this Jan 5, 2023
@haerdib haerdib changed the title add submit opaque extrinsic Add submit opaque extrinsic Jan 5, 2023
@haerdib haerdib added F7-enhancement Enhances an already existing functionality E2-breaksapi labels Jan 5, 2023
@haerdib haerdib requested a review from clangenb January 5, 2023 16:12
@haerdib haerdib changed the title Add submit opaque extrinsic Add submit opaque extrinsic as Bytes and remove hex utils Jan 5, 2023
@haerdib haerdib changed the title Add submit opaque extrinsic as Bytes and remove hex utils Add submit opaque extrinsic as Bytes and remove hex utils Jan 5, 2023
@haerdib haerdib changed the title Add submit opaque extrinsic as Bytes and remove hex utils Add submit_opaque_extrinsic as Bytes and remove hex utils Jan 5, 2023
@haerdib haerdib mentioned this pull request Jan 6, 2023
Merged
1 task
@haerdib haerdib changed the title Add submit_opaque_extrinsic as Bytes and remove hex utils Add submit_opaque_extrinsic and related Jan 6, 2023
@haerdib haerdib changed the title Add submit_opaque_extrinsic and related Add submit_opaque_extrinsic and enfore UncheckedExtrinsic on `submit_extrinsic Jan 6, 2023
@haerdib haerdib changed the title Add submit_opaque_extrinsic and enfore UncheckedExtrinsic on `submit_extrinsic Add submit_opaque_extrinsic and enfore UncheckedExtrinsic on submit_extrinsic Jan 6, 2023
@haerdib haerdib changed the title Add submit_opaque_extrinsic and enfore UncheckedExtrinsic on submit_extrinsic Enfore UncheckedExtrinsicV4 on submit_.._extrinsic, add .._opaque_extrinsic Jan 6, 2023
@haerdib haerdib changed the title Enfore UncheckedExtrinsicV4 on submit_.._extrinsic, add .._opaque_extrinsic Enforce UncheckedExtrinsicV4 on submit_.._extrinsic, add .._opaque_extrinsic Jan 6, 2023
@haerdib haerdib changed the title Enforce UncheckedExtrinsicV4 on submit_.._extrinsic, add .._opaque_extrinsic Enforce UncheckedExtrinsicV4 on submit_extrinsic and add _opaque_extrinsic Jan 6, 2023
@haerdib haerdib changed the title Enforce UncheckedExtrinsicV4 on submit_extrinsic and add _opaque_extrinsic Enforce UncheckedExtrinsicV4 for submit_extrinsic and add _opaque_extrinsic Jan 6, 2023
@haerdib haerdib marked this pull request as ready for review January 6, 2023 08:17
clangenb
clangenb approved these changes Jan 7, 2023
View reviewed changes
Copy link
Collaborator

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I approve!

@haerdib haerdib requested a review from Niederb January 9, 2023 07:10
Niederb
Niederb approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@Niederb Niederb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haerdib haerdib merged commit c1cad34 into master Jan 9, 2023
@haerdib haerdib deleted the bh/90-add-send-xt branch January 9, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb approved these changes

@Niederb Niederb Niederb approved these changes

Assignees

@haerdib haerdib

Labels
E2-breaksapi F7-enhancement Enhances an already existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add method: fn send_xt<C: Encode>(xt: UncheckedExtrinsic<C>, xt_status: XtStatus)
3 participants
@haerdib @Niederb @clangenb