Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce Bytes and remove obsolete hex-utils #423

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Enforce Bytes and remove obsolete hex-utils #423

merged 2 commits into from
Jan 10, 2023

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Jan 6, 2023 •
edited
Loading

closes #395

@haerdib haerdib self-assigned this Jan 6, 2023
@haerdib haerdib changed the title Bh/395 remove hex utils Enforce Bytes and remove oboslete hex-utils Jan 6, 2023
@haerdib haerdib marked this pull request as ready for review January 9, 2023 09:49
@haerdib haerdib added F7-enhancement Enhances an already existing functionality E1-breaksnothing labels Jan 9, 2023
@haerdib haerdib changed the title Enforce Bytes and remove oboslete hex-utils Enforce Bytes and remove obsolete hex-utils Jan 9, 2023
@haerdib
remove hex utils
a95bf01 
remove utils

fix build

fix rebase
Niederb
Niederb reviewed Jan 9, 2023
View reviewed changes
Copy link
Contributor

@Niederb Niederb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the question regarding E1-breaksnothing this looks good to me.

src/lib.rs Show resolved Hide resolved
@haerdib haerdib requested a review from Niederb January 10, 2023 07:07
@haerdib haerdib merged commit 3fd9cba into master Jan 10, 2023
@haerdib haerdib deleted the bh/395-remove-hex-utils branch January 10, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Niederb Niederb Niederb approved these changes

@clangenb clangenb Awaiting requested review from clangenb

Assignees

@haerdib haerdib

Labels
E2-breaksapi F7-enhancement Enhances an already existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate use of array-bytes or Bytes instead of self implemented from_hex
2 participants
@haerdib @Niederb