feat: map AniDB IDs from Hama agent to tvdb/tmdb/imdb IDs #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello there, While I haven't looked over the code, I should mention that HAMA no longer uses Scudlee's repo as it has become stale and inactive. They've switched to this one which is more active and actually maintained: https://github.com/Anime-Lists/anime-lists As can be seen here: It might be best to make the same switch. Kind regards, |
|
Oh, nice that seems to be more up to date. Will switch to that. |
sct
requested changes
Dec 31, 2020
sct
approved these changes
Jan 7, 2021
… twice Hama agent can have same tvdbid it for different library items - for example when user stores different seasons for same tv show separately. This change adds "AsyncLock" that guarantees code in callback runs for same id fully, before running same callback next time.
… anidb/hama agent
|
🎉 This PR is included in version 1.17.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds hama agent support - maps AniDB IDs to tvdb/tmdb/imdb IDs. So once anime is identified in Plex for hama agent libraries, it will show up available as tv show or movie.
Hama agent stores tvdb or anidb in guid. See Absolute Series Scanner for details how it can be configured: https://github.com/ZeroQI/Absolute-Series-Scanner
If tvdb is detected in guid, then same code as regular tvdb lookups is used to map it to tvshow.
If anidb is detected in guid, then it is remapped using ScudLee mappings xml : https://github.com/ScudLee/anime-lists/ These are same mappings that Hama agent uses for matching metadata to content. XML mappings are downloaded once a day and cached on local disk (
config/anime-list.xmlfile).Because of way how hama stores movies in Special season of tv show library, there's extra code in processShows to create movies. Either directly or by walking over each episode in Specials/ Season0 to try to map it to tmdb/imdb.
The solution is not ideal, as unknown anidb ids are not mapped at all, just skipped - same as before. But that's basically issue with ScudLee mappings - you need to go to their repo and update mappings, if you want missing/newer stuff to be picked up.
I've tested this on my 500+ anime library, and I see most of the stuff being picked up correctly.
Screenshot (if UI related)
Todos
yarn buildyarn i18n:extractIssues Fixed or Closed by this PR