Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search returning no results when [include] or [exclude] set on <emoji-mart> #172

Closed
s-moran opened this issue Oct 27, 2018 · 5 comments · Fixed by #274
Closed

Search returning no results when [include] or [exclude] set on <emoji-mart> #172

s-moran opened this issue Oct 27, 2018 · 5 comments · Fixed by #274
Labels
bug help wanted released

Comments

@s-moran
Copy link
Contributor

s-moran commented Oct 27, 2018

For example, using the code below gives a blank search results area. Should be able to search within 'people' category. Works as expected when [include] is removed.

<emoji-mart set="apple" [title]="''" [emojiSize]="16" [emoji]="''" 
[totalFrequentLines]="1" [perLine]="8" (emojiClick)="emojiClick($event)" [include]="['people']">
</emoji-mart>
@zoualmamy
Copy link

Any fix on this yet?

@scttcper
Copy link
Owner

I probably won't be able to get to this, please open a PR

@s-moran
Copy link
Contributor Author

s-moran commented Dec 1, 2019 •
edited
Loading

I'll try to take a look at it ... might also be related to #182

Update: am looking into it now

@scttcper scttcper mentioned this issue Dec 6, 2019
Closed
@s-moran s-moran mentioned this issue Dec 8, 2019
Merged
s-moran pushed a commit to s-moran/ngx-emoji-mart that referenced this issue Dec 8, 2019
Fixes scttcper#172
f256e26
This was referenced Dec 8, 2019
Closed
Merged
scttcper pushed a commit that referenced this issue Dec 8, 2019
@s-moran @scttcper
fix: patch for include and exclude parameters #172 (#274)
8f25f62
@scttcper
Copy link
Owner

scttcper commented Dec 8, 2019

🎉 This issue has been resolved in version 1.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mlembke1
Copy link

mlembke1 commented Dec 9, 2019

@scttcper Thanks for the new release. However, is there a fix for those of us who aren't on Angular 8 yet...?

@rohtashsethi-nag rohtashsethi-nag mentioned this issue Jan 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: patch for include and exclude parameters #172 s-moran/ngx-emoji-mart
4 participants
@scttcper @s-moran @mlembke1 @zoualmamy