Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch for include and exclude parameters #172 #274

Merged
merged 1 commit into from
Dec 8, 2019

Conversation

s-moran
Copy link
Contributor

@s-moran s-moran commented Dec 8, 2019

emoji-search.service.ts: Pool variable was getting set with incorrect id (emojiId) ... needed to grab emoji object first to obtain the correct id, and then set the correct key (emoji.id) on pool object.

picker.component.ts: Was getting console error (undefined object) with small number of categories. This fixes it.

Closes #172

@scttcper scttcper changed the title Fixes #172 fix: broken include and exclude #172 Dec 8, 2019
@scttcper scttcper changed the title fix: broken include and exclude #172 fix: patch for include and exclude parameters #172 Dec 8, 2019
@scttcper scttcper merged commit 8f25f62 into scttcper:master Dec 8, 2019
@scttcper
Copy link
Owner

scttcper commented Dec 8, 2019

🎉 This PR is included in version 1.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search returning no results when [include] or [exclude] set on <emoji-mart>
2 participants