Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ Various improvements to scatter_density #43

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

grst
Copy link
Collaborator

@grst grst commented Jun 27, 2023

  • support for layer
  • fix some type hints
  • automatically infer x/y axis labels from x/y parameters
  • remove arbitrary hardcoded axis limits (now defaults to max observed value in the respective dimension)

@codecov-commenter
Copy link

Codecov Report

Merging #43 (d8ad248) into main (6b37445) will increase coverage by 0.24%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   80.41%   80.66%   +0.24%     
==========================================
  Files          10       10              
  Lines         388      393       +5     
==========================================
+ Hits          312      317       +5     
  Misses         76       76              
Impacted Files Coverage Δ
pytometry/plotting/_scatter_density.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -8,6 +8,7 @@ authors = [{name = "Maren Buettner", email = "maren.buettner@helmholtz-muenchen.
readme = "README.md"
dynamic = ["version"]
description = "Pytometry is a Python package for flow and mass cytometry analysis."
requires-python = '>= 3.9'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.9 is the lowest python version that is still supported by numpy (see "NEP29") and is also used across scverse packages.
Having Python >= 3.8 as a minimum requirement enables use of the Literal type.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fine for me.

@mbuttner mbuttner changed the title Various improvements to scatter_density ⚡ Various improvements to scatter_density Jun 27, 2023
@mbuttner mbuttner merged commit 02f37a7 into scverse:main Jun 27, 2023
@grst grst deleted the scatterplot-improvements branch June 27, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants