[UPDATE] speed_tester jumbo frames crash fix #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisafa
reviewed
Nov 23, 2021
examples/speed_tester/speed_tester.c
Outdated
| @@ -334,6 +342,10 @@ nf_setup(struct onvm_nf_local_ctx *nf_local_ctx) { | |||
| if (pkt == NULL) | |||
| break; | |||
|
|
|||
| /* Length of the packet cannot exceed preallocated storage size */ | |||
| if (header.caplen > max_elt_size) | |||
There was a problem hiding this comment.
On line 341: pkt = rte_pktmbuf_alloc(pktmbuf_pool); But you continue here without freeing that packet. Perhaps move this continue statement before the allocation occurs?
[UPDTE] speed_tester jumbo frame usability improvement
|
Updated functionality based on Dennis and Tim's comments. |
dennisafa
approved these changes
Dec 3, 2021
twood02
approved these changes
Jan 21, 2022
twood02
added a commit
that referenced
this pull request
Aug 3, 2022
Merge branch 'develop' of https://github.com/sdnfv/openNetVM into jettjacobs-docs * 'develop' of https://github.com/sdnfv/openNetVM: Python Script Update (#325) LB Adjustments; Run without mTCP (#322) Fix incorrect comment (#323) Scaling Example NF Updates (#321) ONVM 21.10 [Bug Fix] speed_tester jumbo frames crash fix (#316) [Bug Fix] ARP endianess fixed (#317)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Speed tester will no longer crash if you tell it to load a PCAP trace that contains jumbo frames without using the -j flag.
Usage:
Merging notes:
TODO before merging :
Test Plan:
Started manager without -j flag and successfully ran the speed tester using several PCAP files which contained jumbo frames.