ARP Endianness Fixed #317
Merged
ARP Endianness Fixed #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twood02
approved these changes
Dec 1, 2021
|
@dennisafa you can merge this into develop and master |
dennisafa
pushed a commit
that referenced
this pull request
Dec 2, 2021
Changes the source IP address in ARP reply from CPU byte ordering to BE. Commit log: * ARP endianess fixed
|
Merged into master as well via cherry-pick. @twood02 |
catherinemeadows
added a commit
that referenced
this pull request
Mar 28, 2022
* [Bug Fix] ARP endianess fixed (#317) Changes the source IP address in ARP reply from CPU byte ordering to BE. Commit log: * ARP endianess fixed * change children service id to match parent * update README * update README & fix typo * update README Co-authored-by: Noah Chinitz <62520433+NoahChinitzGWU@users.noreply.github.com> Co-authored-by: CMeadows <CMeadows@localhost>
catherinemeadows
added a commit
that referenced
this pull request
Jul 7, 2022
* [Bug Fix] ARP endianess fixed (#317) Changes the source IP address in ARP reply from CPU byte ordering to BE. Commit log: * ARP endianess fixed * update clock for py 3.8 Co-authored-by: Noah Chinitz <62520433+NoahChinitzGWU@users.noreply.github.com> Co-authored-by: CMeadows <CMeadows@localhost>
twood02
added a commit
that referenced
this pull request
Aug 3, 2022
Merge branch 'develop' of https://github.com/sdnfv/openNetVM into jettjacobs-docs * 'develop' of https://github.com/sdnfv/openNetVM: Python Script Update (#325) LB Adjustments; Run without mTCP (#322) Fix incorrect comment (#323) Scaling Example NF Updates (#321) ONVM 21.10 [Bug Fix] speed_tester jumbo frames crash fix (#316) [Bug Fix] ARP endianess fixed (#317)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The byte ordering of the ARP Response NF was correctly getting MAC address, but would get the IP address backwards. With a quick one line fix using
rte_cpu_to_be_32the MAC address and IP address are both correct.Before:
As you can see the IP address reported by the ARP response is 1.1.10.10, when in fact the correct IP is 10.10.1.1.
We can see here that the HWAddress of
onvm-link-0is incomplete.After:
We can see that ARP was giving a response and finding it at
onvm-link-0.I was able to verify that
onvm-link-0is the correct hostname fromarp -vas well as usingarpingSummary:
Usage:
Merging notes:
TODO before merging :
Test Plan:
The change was tested using
arping,tcpdump,arp -v, androute -nto ensure correct MAC and IP.