Update RuboCop and fix failing spec #465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
force-pushed
the
chore/464-fix-spec
branch
3 times, most recently
from
a2b2d50
to
960e796
Compare
A new offense in RuboCop causes an issue when running specs locally. This commit fixes the behavior by making RuboCop happy with `each_key`. In this context, this should be safe because the test is checking if haml-lint works when a comment is added to an anonymous block Close sds#464
tagliala
force-pushed
the
chore/464-fix-spec
branch
from
960e796
to
1b22816
Compare
|
Thanks for the PR! Apologies—I merged #470 before realizing it was solving the same issue as this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not know if this is correct
A new offense in RuboCop causes an issue when running specs locally.
This commit fixes the behavior by making RuboCop happy with
each_key.In this context, this should be safe because the test is checking
if haml-lint works when a comment is added to an anonymous block
Close #464