Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RuboCop and fix failing spec #465

Closed
wants to merge 1 commit into from
Closed

Update RuboCop and fix failing spec #465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,5 @@ appraise 'haml6.3' do
end

appraise 'rubocop1.0' do
gem 'rubocop', '~> 1.0.0'
gem 'rubocop', '~> 1.59.0'
end
2 changes: 1 addition & 1 deletion gemfiles/haml5.0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "rspec", "~> 3.8"
gem "rspec-its", "~> 1.0"
gem "appraisal"
gem "overcommit", "0.60.0"
gem "rubocop", "1.57.2"
gem "rubocop", "1.59.0"
gem "simplecov", "~> 0.22.0"
gem "simplecov-lcov", "~> 0.8.0"
gem "haml", "~> 5.0.0"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/haml5.1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "rspec", "~> 3.8"
gem "rspec-its", "~> 1.0"
gem "appraisal"
gem "overcommit", "0.60.0"
gem "rubocop", "1.57.2"
gem "rubocop", "1.59.0"
gem "simplecov", "~> 0.22.0"
gem "simplecov-lcov", "~> 0.8.0"
gem "haml", "~> 5.1.0"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/haml5.2.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "rspec", "~> 3.8"
gem "rspec-its", "~> 1.0"
gem "appraisal"
gem "overcommit", "0.60.0"
gem "rubocop", "1.57.2"
gem "rubocop", "1.59.0"
gem "simplecov", "~> 0.22.0"
gem "simplecov-lcov", "~> 0.8.0"
gem "haml", "~> 5.2.0"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/haml6.0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "rspec", "~> 3.8"
gem "rspec-its", "~> 1.0"
gem "appraisal"
gem "overcommit", "0.60.0"
gem "rubocop", "1.57.2"
gem "rubocop", "1.59.0"
gem "simplecov", "~> 0.22.0"
gem "simplecov-lcov", "~> 0.8.0"
gem "haml", "~> 6.0.0"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/haml6.1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "rspec", "~> 3.8"
gem "rspec-its", "~> 1.0"
gem "appraisal"
gem "overcommit", "0.60.0"
gem "rubocop", "1.57.2"
gem "rubocop", "1.59.0"
gem "simplecov", "~> 0.22.0"
gem "simplecov-lcov", "~> 0.8.0"
gem "haml", "~> 6.1.0"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/haml6.2.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "rspec", "~> 3.8"
gem "rspec-its", "~> 1.0"
gem "appraisal"
gem "overcommit", "0.60.0"
gem "rubocop", "1.57.2"
gem "rubocop", "1.59.0"
gem "simplecov", "~> 0.22.0"
gem "simplecov-lcov", "~> 0.8.0"
gem "haml", "~> 6.2.0"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/haml6.3.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "rspec", "~> 3.8"
gem "rspec-its", "~> 1.0"
gem "appraisal"
gem "overcommit", "0.60.0"
gem "rubocop", "1.57.2"
gem "rubocop", "1.59.0"
gem "simplecov", "~> 0.22.0"
gem "simplecov-lcov", "~> 0.8.0"
gem "haml", "~> 6.3.0"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rubocop1.0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "rspec", "~> 3.8"
gem "rspec-its", "~> 1.0"
gem "appraisal"
gem "overcommit", "0.60.0"
gem "rubocop", "~> 1.0.0"
gem "rubocop", "~> 1.59.0"
gem "simplecov", "~> 0.22.0"
gem "simplecov-lcov", "~> 0.8.0"

Expand Down
8 changes: 4 additions & 4 deletions spec/haml_lint/linter/rubocop_autocorrect_examples/script_examples.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,22 +462,22 @@ haml_lint_marker_9


!!! Handles an anonymous block with a trailing comment
- list.each do |var, var2| # Some comment
- list.each_key do |var| # Some comment
= foo(:bar => 123)
---
haml_lint_marker_1
list.each do |var, var2| # Some comment
list.each_key do |var| # Some comment
HL.out = foo(:bar => 123) $$2
end
haml_lint_marker_5
---
haml_lint_marker_1
list.each do |_var, _var2| # Some comment
list.each_key do |_var| # Some comment
HL.out = foo(bar: 123)
end
haml_lint_marker_5
---
- list.each do |_var, _var2| # Some comment
- list.each_key do |_var| # Some comment
= foo(bar: 123)


Expand Down