Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match DESI arc lines selection to improve wavelength solutions #131

Closed
ajmejia opened this issue Aug 7, 2024 · 3 comments
Closed

Match DESI arc lines selection to improve wavelength solutions #131

ajmejia opened this issue Aug 7, 2024 · 3 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@ajmejia
Copy link
Contributor

ajmejia commented Aug 7, 2024

In PR #129 we tested the improved routines for wavelength/LSF fitting on our original selection of arc lines across different channels, with no significant improvements.

As an experiment in the NIR channel, we matched (as much as possible) DESI arc lines selection. This (combined with fitting a higher polynomial degree) lead to an improvement of ~0.03 (from 0.07 to 0.04) Angstroms in some cases. We can match DESI's selection in all remaining channels. This should significantly improve b channel wavelength residuals.

Related to this, the following are the remaining bugs in wavelength fittings in different cameras:

Clear outlying fibers in b3:
lvm-mwave-b3_fit_wave

Systematic offset in some fibers (possibly block boundaries) in z3:
lvm-mwave-z3_fit_lsf

Clear break close to the middle of the chip (fiber ~331) while fitting a 5th order polynomial in z1:
image

The last one we explored a bit more. We tried replacing lines that show this bimodal behavior in the residuals with no success. This feature is present in all calibration epochs only in z1.

@ajmejia ajmejia added bug Something isn't working enhancement New feature or request labels Aug 7, 2024
@ajmejia
Copy link
Contributor Author

ajmejia commented Aug 23, 2024

The bug in z3 is happening in sky fibers and could be a instrument feature being captured by the wavelength and LSF fitting.

The b3 one, seems to be related to a absorption-like feature that appears in fibers around 372 in arc line 3593 Ang.

@gblancm
Copy link
Contributor

gblancm commented Aug 26, 2024 via email

@ndrory
Copy link
Contributor

ndrory commented Sep 23, 2024

We consider this fixed in 1.1dev. Further improvements to wavelength solutions, if needed, should open a new issue.

@ndrory ndrory closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants