Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving wavelength/LSF fitting routines #129

Merged
merged 39 commits into from
Aug 7, 2024
Merged

Improving wavelength/LSF fitting routines #129

merged 39 commits into from
Aug 7, 2024

Conversation

ajmejia
Copy link
Contributor

@ajmejia ajmejia commented Aug 5, 2024 •
edited
Loading

This PR implements various improvements in wavelength and LSF fitting routines, namely:

  • Implemented handling of boundaries
  • Improved management of bad pixels during arc lines fitting
  • Improved QA plots
  • Removed cross-dispersion smoothing of LSF
  • Increased degree of polynomial fitting to improve fitting of higher (>2) order terms
  • Fixes missing lines when too close to chip edges
  • Fixes issue Wavelength sky shift sometimes shows a trend that is not corrected #89 with a proper fitting of sky lines & trend as a function of Y pixel position
  • Other minor bug fixes

ajmejia added 30 commits July 18, 2024 20:53
@ajmejia
re-working wavelength fitting routines to better handling of boundari…
2412af4 
…es & bug fixes
@ajmejia
fixing typo & bug in lvmArc creation
486b40d
@ajmejia
implementing QA plot for Guassian fitting given a list of fibers
3fad9f6
@ajmejia
implementing correction for arc line flux guess
7b0b2cc
@ajmejia
fixing handling of out-of-bounds fits
da5bb38
@ajmejia
rolling back xtol and ftol values
9a0bc44
@ajmejia
updating flux boundaries
ce5ac89
@ajmejia
further adjustment to flux boundaries
b009f89
@ajmejia
moving guess fix to fitter class
60126fc
@ajmejia
Merge branch 'master' into fixwaveshifts
2bb568f
@ajmejia
fixing missing max_diff argument
e2c0edf
@ajmejia
Merge branch 'master' into fixwaveshifts
5dbadcd
@ajmejia
changing default fitting method for a faster one
894a6dc
@ajmejia
Merge branch 'master' into fixwaveshifts
3c9eeae
@ajmejia
implementing proper centroid boundaries
0002960
@ajmejia
adding resulting parameters to Gaussian fitting plot
71ec521
@ajmejia
accounting for masked lines
892bee0
@ajmejia
removing redundant logging
76186ae
@ajmejia
fixed pixel masking and line masking & updated defaults
e01b90e
@ajmejia
fixing guess centroids with refinement
74832c2
@ajmejia
fixing pix2wave script to work in Mac
9cbf274
@ajmejia
Merge branch 'master' into fixwaveshifts
5e3b400
@ajmejia
fixing choice of fitting bg or not
9524c94
@ajmejia
adding continuum subtraction in wavelength fitting routine
225594e
@ajmejia
improving centroids guess
d1d6756
@ajmejia
fixing side effect in _corss_match_float inputs
63d9af6
@ajmejia
fixing interpolations in wave/LSF fits
4455b56
@ajmejia
fixing typo in defaults
f73123d
@ajmejia
new defaults for continuum fitting and subtraction
ff4f651
@ajmejia
returning background & fixing centroid guess
260b59c
@ajmejia ajmejia added bug Something isn't working enhancement New feature or request labels Aug 5, 2024
@ajmejia ajmejia marked this pull request as ready for review August 7, 2024 15:17
@ajmejia ajmejia merged commit ff1a4ef into master Aug 7, 2024
8 checks passed
@ajmejia ajmejia deleted the fixwaveshifts branch August 7, 2024 15:25
This was referenced Aug 7, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ajmejia