Add an implementation for RequestBuilder::from_parts and RequestBuilder::build_split for wasm targets #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickguletskii
changed the title
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Jun 18, 2024
Bumps reqwest from 0.12.4 to 0.12.5. Release notes Sourced from reqwest's releases. v0.12.5 What's Changed Add http3 feature back, still requiring reqwest_unstable. Add rustls-tls-no-provider Cargo feature to use rustls without a crypto provider. Add blocking::ClientBuilder::dns_resolver() method to change DNS resolver in blocking client. Fix Accept-Encoding header combinations. Fix http3 resolving IPv6 addresses. Internal: upgrade to rustls 0.23. New Contributors @bnjmnjrk made their first contribution in seanmonstar/reqwest#2253 @d-e-s-o made their first contribution in seanmonstar/reqwest#2257 @mger1 made their first contribution in seanmonstar/reqwest#2260 @nickguletskii made their first contribution in seanmonstar/reqwest#2268 @lenstr made their first contribution in seanmonstar/reqwest#2271 @torokati44 made their first contribution in seanmonstar/reqwest#2274 @jayvdb made their first contribution in seanmonstar/reqwest#2284 @adamaq01 made their first contribution in seanmonstar/reqwest#2288 @asonix made their first contribution in seanmonstar/reqwest#2301 Full Changelog: seanmonstar/reqwest@v0.12.4...v0.12.5 Changelog Sourced from reqwest's changelog. v0.12.5 Add blocking::ClientBuilder::dns_resolver() method to change DNS resolver in blocking client. Add http3 feature back, still requiring reqwest_unstable. Add rustls-tls-no-provider Cargo feature to use rustls without a crypto provider. Fix Accept-Encoding header combinations. Fix http3 resolving IPv6 addresses. Internal: upgrade to rustls 0.23. Commits 29d4cff v0.12.5 a7880d6 tests: fix http3 tests c32d877 tests: enable http3 content-length test ce3b30e http3: send content-length if known 404df59 test: add http3 test server support e5ce0b5 fix: don't enable hyper-rustls/http2 unless http2 is already enabled ccb5e40 Don't compile hyper-tls with native-roots unless rustls-tls-native-roots is e... c56fbae tests: remove a proxy parse error check 8cc7cd4 msrv: pin url 695bc04 fix: http3 resolving ipv6 addresses (#2305) Additional commits viewable in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Nutomic
pushed a commit
to Nutomic/reqwest
that referenced
this pull request
Nov 7, 2024
…tBuilder::build_split for wasm targets (seanmonstar#2268)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the implementation of
RequestBuilderfor WASM targets lacks an implementation ofRequestBuilder::from_partsandRequestBuilder::build_split. I noticed this when the latest version ofreqwest-middlewarefailed to compile for wasm32-unknown-unknown because these methods are missing.Unless I am missing something, it should be safe to add these methods and let third party crates use them just like on native platforms.