Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect Accept-Encoding header combinations in Accepts::as_str #2271

Merged
merged 1 commit into from
May 1, 2024

Conversation

lenstr
Copy link
Contributor

@lenstr lenstr commented May 1, 2024

This pull request addresses a bug in the Accepts::as_str method where incorrect header combinations were returned for certain configurations. Specifically, the method incorrectly included 'zstd' in some combinations where it should not have been.

Copy link
Owner

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@seanmonstar seanmonstar merged commit c654bb0 into seanmonstar:master May 1, 2024
34 checks passed
kodiakhq bot pushed a commit to pdylanross/fatigue that referenced this pull request Jun 18, 2024
Bumps reqwest from 0.12.4 to 0.12.5.

Release notes
Sourced from reqwest's releases.

v0.12.5
What's Changed

Add http3 feature back, still requiring reqwest_unstable.
Add rustls-tls-no-provider Cargo feature to use rustls without a crypto provider.
Add blocking::ClientBuilder::dns_resolver() method to change DNS resolver in blocking client.
Fix Accept-Encoding header combinations.
Fix http3 resolving IPv6 addresses.
Internal: upgrade to rustls 0.23.

New Contributors

@​bnjmnjrk made their first contribution in seanmonstar/reqwest#2253
@​d-e-s-o made their first contribution in seanmonstar/reqwest#2257
@​mger1 made their first contribution in seanmonstar/reqwest#2260
@​nickguletskii made their first contribution in seanmonstar/reqwest#2268
@​lenstr made their first contribution in seanmonstar/reqwest#2271
@​torokati44 made their first contribution in seanmonstar/reqwest#2274
@​jayvdb made their first contribution in seanmonstar/reqwest#2284
@​adamaq01 made their first contribution in seanmonstar/reqwest#2288
@​asonix made their first contribution in seanmonstar/reqwest#2301

Full Changelog: seanmonstar/reqwest@v0.12.4...v0.12.5



Changelog
Sourced from reqwest's changelog.

v0.12.5

Add blocking::ClientBuilder::dns_resolver() method to change DNS resolver in blocking client.
Add http3 feature back, still requiring reqwest_unstable.
Add rustls-tls-no-provider Cargo feature to use rustls without a crypto provider.
Fix Accept-Encoding header combinations.
Fix http3 resolving IPv6 addresses.
Internal: upgrade to rustls 0.23.




Commits

29d4cff v0.12.5
a7880d6 tests: fix http3 tests
c32d877 tests: enable http3 content-length test
ce3b30e http3: send content-length if known
404df59 test: add http3 test server support
e5ce0b5 fix: don't enable hyper-rustls/http2 unless http2 is already enabled
ccb5e40 Don't compile hyper-tls with native-roots unless rustls-tls-native-roots is e...
c56fbae tests: remove a proxy parse error check
8cc7cd4 msrv: pin url
695bc04 fix: http3 resolving ipv6 addresses (#2305)
Additional commits viewable in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants