Adding new and improving existing member methods of Node
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We merged `getDescendantForByteRange` and `getDescendantForPointRange` into `getDescendant`, which has two signatures, one for byte and the other for `Point`. An unfortunate side effect of this is that the name of the JNIEXPORT is rather long now.
Includes both variants for byte- and point-based ranges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods that have been added:
getDescendantgetNamedDescendantBoth methods take in as argument a byte or
Pointrange to search for the descendants. Note that the existinggetDescendantForByteRangemethod will be deprecated in favour of the new additions. Apart from that, changes have been made togetChildrenin order to reduce the number of native code calls from n to 1.