Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new and improving existing member methods of Node #21

Merged
merged 10 commits into from
Sep 25, 2023
Merged

Adding new and improving existing member methods of Node #21

merged 10 commits into from
Sep 25, 2023

Commits on Sep 25, 2023

  1. Added getDescendantForPointRange to Node

    @dabico
    dabico committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    06be84e View commit details
    Browse the repository at this point in the history

  2. Added more defensive programming to getDescendantForByteRange

    @dabico
    dabico committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    d91ffe7 View commit details
    Browse the repository at this point in the history

  3. Removed obsolete assertion

    @dabico
    dabico committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    0208529 View commit details
    Browse the repository at this point in the history

  4. Merging two similarly named methods into single overloaded variant 

    We merged `getDescendantForByteRange` and `getDescendantForPointRange`
into `getDescendant`, which has two signatures, one for byte and the
other for `Point`. An unfortunate side effect of this is that the name
of the JNIEXPORT is rather long now.
    @dabico
    dabico committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    769fa95 View commit details
    Browse the repository at this point in the history

  5. OffsetTreeCursor no longer overrides deprecated methods

    @dabico
    dabico committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    834780e View commit details
    Browse the repository at this point in the history

  6. Moving position of test, ignore this commit

    @dabico
    dabico committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    8681909 View commit details
    Browse the repository at this point in the history

  7. Added getNamedDescendant to Node 

    Includes both variants for byte- and point-based ranges.
    @dabico
    dabico committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    e9ea43a View commit details
    Browse the repository at this point in the history

  8. New Node methods are properly overridden in OffsetTreeCursor

    @dabico
    dabico committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    673640f View commit details
    Browse the repository at this point in the history

  9. Minor refactoring of the new getDescendant methods to minimize dupes

    @dabico
    dabico committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    57babf4 View commit details
    Browse the repository at this point in the history

  10. The getChildren method in Node now uses only one native call

    @dabico
    dabico committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    478f083 View commit details
    Browse the repository at this point in the history