Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements to Parser.Builder API #48

Merged
merged 7 commits into from
Oct 31, 2023
Merged

Enhancements to Parser.Builder API #48

merged 7 commits into from
Oct 31, 2023

Conversation

dabico
Copy link
Member

@dabico dabico commented Oct 30, 2023 •
edited
Loading

Two new additions have been made to the API:

  • Methods for directly specifying the Parser timeout have been added
  • Added a toBuilder method which acts as a means of duplicating Parser instances

@dabico
Extracting the exception messages into their static variables
700aada 
We will be reusing them for the new additions
@dabico
Minor documentation update
4d627c4
@dabico
Separating noop parser setter assertions into their own test
d0aa0ba
@dabico
Minor documentation update to explicitly mention timeout disabling
5c59e70
@dabico
Minor documentation update (again)
ae6bfb4
@dabico
Parser builder now also supports specifying the timeout
cd2a930 
Building without invoking any of the new methods retains the old
behaviour: no timeouts are applied. The static factory will not be
modified, as introducing overloaded variants for each timeout signature
will pollute the API.
@dabico
Add toBuilder method to Parser
79807c6
@dabico dabico mentioned this pull request Oct 31, 2023
Merged
@dabico dabico merged commit 353e27c into master Oct 31, 2023
2 checks passed
@dabico dabico deleted the enhancement/parser branch October 31, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dabico