Enhancements to Query.Builder API
#49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not modify the native code, as all the patterns are joined at the very end to form a single pattern which is then fed to the tree-sitter API.
This variant is intended for specifying multiple patterns in one method call. Although specifying the concatenation is technically correct, this variant should be more easily readable.
Its purpose is to clear all the currently set patterns. This will be of use when we introduce `toBuilder`.
Unlike `patterns(String...)` which mutates the pattern list by adding, this variant is intended explicitly for overwriting the currently set patterns with a completely new list. This method will essentially make `Query` mutations possible when `toBuilder` is introduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest change of this PR is that patterns can now be specified and added individually, overwritten with a new list of patterns and even reset. A lot of inspiration was borrowed from #48, including the
toBuilder. The static factory was also changed to offer support for these features.