Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opcache.jit validation #69

Closed
wants to merge 3 commits into from
Closed

Conversation

joanhey
Copy link
Contributor

@joanhey joanhey commented Apr 8, 2023

https://www.php.net/manual/en/opcache.configuration.php#ini.opcache.jit

The first '0' only disables the CPU-specific optimization, not the JIT.

@joanhey
Copy link
Contributor Author

joanhey commented Apr 8, 2023

By default in Debian and Ubuntu, using ppa:ondrej/php is off.
oerdnj/deb.sury.org#1924

.../conf.d/10-opcache.ini

; configuration for php opcache module
; priority=10
zend_extension=opcache.so
opcache.jit=off

So be careful, because overwrite the value in php.ini.

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #69 (8b2990f) into main (c336cb9) will decrease coverage by 1.47%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main      #69      +/-   ##
============================================
- Coverage     56.63%   55.17%   -1.47%     
- Complexity       65       67       +2     
============================================
  Files             2        2              
  Lines           113      116       +3     
============================================
  Hits             64       64              
- Misses           49       52       +3     
Impacted Files Coverage Δ
src/Runtime.php 50.50% <0.00%> (-1.58%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sebastianbergmann
Copy link
Owner

sebastianbergmann commented Apr 10, 2023

After merging #68, there is now a merge conflict. Please update this pull request. Thanks!

@sebastianbergmann
Copy link
Owner

This branch cannot be rebased due to conflicts.

@joanhey
Copy link
Contributor Author

joanhey commented Apr 10, 2023

Fixed in #70

@joanhey joanhey closed this Apr 10, 2023
@joanhey joanhey deleted the patch-2 branch April 10, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants